Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPPL-2846: [badger_extn]-Error sending badger metrics #699

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

RPPL-2846: [badger_extn]-Error sending badger metrics #699

wants to merge 5 commits into from
+4 −1

Conversation

pahearn73
Copy link
Contributor

Telemetry was being sent but never sending ack to caller, logging an error.

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
device.thunder.src.bootstrap 0% ❌
device.thunder_ripple_sdk.src.processors 10% ❌
core.main.src.processor.storage 0% ❌
core.sdk.src.extn 83% ✔
core.sdk.src.extn.ffi 80% ✔
core.launcher.src.manager 7% ❌
core.main.src.firebolt 3% ❌
core.sdk.src.api.gateway 66% ➖
device.thunder.src 0% ❌
core.main.src 0% ❌
core.sdk.src.utils 49% ➖
core.sdk.src.api.distributor 84% ✔
core.main.src.firebolt.handlers 9% ❌
device.thunder_ripple_sdk.src.client 74% ➖
core.main.src.service.apps 47% ➖
core.main.src.bootstrap 0% ❌
core.sdk.src.api.manifest 89% ✔
device.thunder_ripple_sdk.src.events 4% ❌
core.main.src.utils 26% ❌
distributor.general.src 2% ❌
device.thunder_ripple_sdk.src.processors.events 0% ❌
core.sdk.src.api.firebolt 77% ✔
core.sdk.src.api.device 77% ✔
core.sdk.src.api.observability 48% ➖
core.launcher.src 0% ❌
core.main.src.broker.thunder 22% ❌
core.main.src.service.extn 40% ❌
core.sdk.src.extn.client 90% ✔
core.main.src.state 23% ❌
core.main.src.bootstrap.extn 0% ❌
core.tdk.src.gateway 100% ✔
core.main.src.state.cap 43% ➖
core.tdk.src.utils 0% ❌
core.main.src.processor 0% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.main.src.broker 45% ➖
device.thunder_ripple_sdk.src 15% ❌
device.mock_device.src 54% ➖
openrpc_validator.src 74% ➖
core.main.src.bootstrap.manifest 0% ❌
core.main.src.service 31% ❌
core.sdk.src.framework 75% ➖
core.sdk.src.api 78% ✔
Summary 43% (18509 / 43164) ➖

Minimum allowed line rate is 42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanobra brendanobra brendanobra approved these changes

@Nv-Delle1416 Nv-Delle1416 Awaiting requested review from Nv-Delle1416

@B-Larsen B-Larsen Awaiting requested review from B-Larsen

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pahearn73 @brendanobra